Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining editorial items on TimeZone and Calendar removals #2926

Closed
8 of 12 tasks
ptomato opened this issue Jul 27, 2024 · 5 comments
Closed
8 of 12 tasks

Remaining editorial items on TimeZone and Calendar removals #2926

ptomato opened this issue Jul 27, 2024 · 5 comments
Labels

Comments

@ptomato
Copy link
Collaborator

ptomato commented Jul 27, 2024

This is to coordinate which editorial simplifications are still to be done on #2925. I'm assuming from what I've heard from implementors that it's better to make the spec text as simple as possible, and strip out the observable optimizations we previously added, because they are now unobservable.

Still to do:

  • Check the design principle of processing arguments in order, and make sure it is still followed everywhere
    • requires some updates to test262, since I made some mistakes with this in the original PR
  • Fix DisambiguatePossibleEpochNanoseconds to use language more like UTC in 262, instead of the arbitrary 48-hour window
  • Check in which cases we need IsValidISODateTime checks after creating ISO Date(-Time) records, and in which cases it will already throw anyway
  • Investigate usage of PrepareCalendarFieldsAndFieldNames on Temporal objects, use CalendarISOToDate instead, and simplify PrepareTemporalFields
  • Have CalendarDateFromFields, CalendarYearMonthFromFields, and CalendarMonthDayFromFields return an ISO Date Record
  • Check if there are operations that are now used only once, and inline them
  • Define Calendar Fields record and use enums for field keys, instead of strings
  • Change CalendarFieldDescriptors to CalendarExtraFields and add the conversions to the main table

Consider doing, but maybe in a follow up:

@ptomato ptomato added the meta label Jul 27, 2024
@ptomato
Copy link
Collaborator Author

ptomato commented Jul 27, 2024

cc @arshaw

@arshaw
Copy link
Contributor

arshaw commented Jul 29, 2024

Hi @ptomato, here are some other Editorial changes we should consider for improving clarity/simplicity:

@ptomato
Copy link
Collaborator Author

ptomato commented Jul 29, 2024

Thanks. I already removed plainDateTimeOrRelativeToWillBeUsed in my current draft, so I've just assigned #2836 to myself and will close it when the PR lands.

I think we should do RelativeTo records after landing this PR so I've added it to the bottom checklist, but I'm open to doing it as part of the PR if you feel strongly about it.

@arshaw
Copy link
Contributor

arshaw commented Jul 29, 2024

Sounds good about doing #2837 after this PR

@ptomato
Copy link
Collaborator Author

ptomato commented Aug 22, 2024

I'll close this one now that #2925 is up for review, and open individual issues for whatever is left to do after I work through the editorial backlog.

@ptomato ptomato closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants