Update ecmarkup and codecov #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just released, provides bug fixes and return type checking. Remove a workaround for a bug.
This is useful for checking if we still need this workaround.
The codecov-node uploader is deprecated and just broke permanently. It is replaced by the GitHub Action.
ptomato
force-pushed
the
update-deps
branch
from
219a843
to
d17322e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2945 +/- ##
==========================================
+ Coverage 96.51% 97.47% +0.95%
==========================================
Files 23 22 -1
Lines 12432 10677 -1755
Branches 2258 1872 -386
==========================================
- Hits 11999 10407 -1592
+ Misses 374 270 -104
+ Partials 59 0 -59 ☔ View full report in Codecov by Sentry. |
This was referenced Sep 24, 2024
gibson042
approved these changes
Sep 24, 2024
|
Thanks for the quick review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2931