Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple minor fixes to DifferenceTemporalPlainYearMonth #3047

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

A couple minor fixes to DifferenceTemporalPlainYearMonth #3047

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66d2cc7
Fix typo in DifferenceTemporalPlainYearMonth AO
trflynn89 Nov 21, 2024
22af2b8
Editorial: Remove errant [[Duration]] reference from RoundRelativeDur…
trflynn89 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/plainyearmonth.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ <h1>
1. Let _thisFields_ be ISODateToFields(_calendar_, _yearMonth_.[[ISODate]], ~year-month~).
1. Set _thisFields_.[[Day]] to 1.
1. Let _thisDate_ be ? CalendarDateFromFields(_calendar_, _thisFields_, ~constrain~).
1. Let _otherFields_ be ISODateToFields(_calendar_, _yearMonth_.[[ISODate]], ~year-month~).
1. Let _otherFields_ be ISODateToFields(_calendar_, _other_.[[ISODate]], ~year-month~).
1. Set _otherFields_.[[Day]] to 1.
1. Let _otherDate_ be ? CalendarDateFromFields(_calendar_, _otherFields_, ~constrain~).
1. Let _dateDifference_ be CalendarDateUntil(_calendar_, _thisDate_, _otherDate_, _settings_.[[LargestUnit]]).
Expand All @@ -615,7 +615,7 @@ <h1>
1. Let _isoDateTime_ be CombineISODateAndTimeRecord(_thisDate_, MidnightTimeRecord()).
1. Let _isoDateTimeOther_ be CombineISODateAndTimeRecord(_otherDate_, MidnightTimeRecord()).
1. Let _destEpochNs_ be GetUTCEpochNanoseconds(_isoDateTimeOther_).
1. Set _duration_ to ? RoundRelativeDuration(_duration_, _destEpochNs_, _isoDateTime_, ~unset~, _calendar_, _settings_.[[LargestUnit]], _settings_.[[RoundingIncrement]], _settings_.[[SmallestUnit]], _settings_.[[RoundingMode]]).[[Duration]].
1. Set _duration_ to ? RoundRelativeDuration(_duration_, _destEpochNs_, _isoDateTime_, ~unset~, _calendar_, _settings_.[[LargestUnit]], _settings_.[[RoundingIncrement]], _settings_.[[SmallestUnit]], _settings_.[[RoundingMode]]).
1. Let _result_ be ? TemporalDurationFromInternal(_duration_, ~day~).
1. If _operation_ is ~since~, set _result_ to CreateNegatedTemporalDuration(_result_).
1. Return _result_.
Expand Down
Loading