From b98456b1a836333c0b3b096fd6942f5ef48f3f85 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Bargull?= <andre.bargull@gmail.com>
Date: Thu, 30 May 2024 10:28:56 +0200
Subject: [PATCH] Allow different approximations in the observational Islamic
 calendar

The "islamic" calendar id refers to the observational Islamic calendar
and different implementation may use different algorithms to approximate
when the moon's crescent can be observed. Change the test data to allow
the approximations used in ICU4X in addition to the ones used in ICU4C.
---
 .../Intl402/Temporal/old/islamic-calendars.js | 53 +++++++++++++++----
 1 file changed, 44 insertions(+), 9 deletions(-)

diff --git a/test/staging/Intl402/Temporal/old/islamic-calendars.js b/test/staging/Intl402/Temporal/old/islamic-calendars.js
index dc68093b25..b09dc3f1b4 100644
--- a/test/staging/Intl402/Temporal/old/islamic-calendars.js
+++ b/test/staging/Intl402/Temporal/old/islamic-calendars.js
@@ -12,10 +12,23 @@ features: [Temporal]
 const tests = [
   {
     calendar: "islamic",
-    inLeapYear: false,
-    daysInYear: 354,
-    daysInMonth12: 29,
-    isoDate: "2023-07-18",
+    choices: [
+      // Approximations of the observational Islamic calendar as computed by ICU4C.
+      {
+        inLeapYear: false,
+        daysInYear: 354,
+        daysInMonth12: 29,
+        isoDate: "2023-07-18",
+      },
+
+      // Approximations of the observational Islamic calendar as computed by ICU4X.
+      {
+        inLeapYear: true,
+        daysInYear: 355,
+        daysInMonth12: 30,
+        isoDate: "2023-07-19",
+      }
+    ],
   },
   {
     calendar: "islamic-umalqura",
@@ -33,10 +46,23 @@ const tests = [
   },
   {
     calendar: "islamic-rgsa",
-    inLeapYear: false,
-    daysInYear: 354,
-    daysInMonth12: 29,
-    isoDate: "2023-07-18",
+    choices: [
+      // Approximations of the observational Islamic calendar as computed by ICU4C.
+      {
+        inLeapYear: false,
+        daysInYear: 354,
+        daysInMonth12: 29,
+        isoDate: "2023-07-18",
+      },
+
+      // Approximations of the observational Islamic calendar as computed by ICU4X.
+      {
+        inLeapYear: true,
+        daysInYear: 355,
+        daysInMonth12: 30,
+        isoDate: "2023-07-19",
+      }
+    ],
   },
   {
     calendar: "islamic-tbla",
@@ -48,7 +74,7 @@ const tests = [
 ];
 
 for (const test of tests) {
-  const { calendar, inLeapYear, daysInYear, daysInMonth12, isoDate } = test;
+  const { calendar, choices = [test] } = test;
   const year = 1445;
   const date = Temporal.PlainDate.from({ year, month: 1, day: 1, calendar });
   assert.sameValue(date.calendarId, calendar);
@@ -56,6 +82,15 @@ for (const test of tests) {
   assert.sameValue(date.month, 1);
   assert.sameValue(date.monthCode, "M01");
   assert.sameValue(date.day, 1);
+
+  // Match the possible choice by comparing the ISO date value.
+  const choice = choices.find(({ isoDate }) => {
+    return date.toString().startsWith(isoDate);
+  });
+  assert(choice !== undefined, `No applicable choice found for calendar: ${calendar}`);
+
+  const { inLeapYear, daysInYear, daysInMonth12, isoDate } = choice;
+
   assert.sameValue(date.inLeapYear, inLeapYear);
   assert.sameValue(date.daysInYear, daysInYear);
   assert.sameValue(date.monthsInYear, 12);