Add tests for Symbol.prototype.description #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jun 7, 2018
| const desc = Object.getOwnPropertyDescriptor(Symbol.prototype, 'description'); | ||
| assert.sameValue(typeof desc.get, 'function'); | ||
| assert.sameValue(desc.set, undefined); | ||
| assert.sameValue(desc.writable, undefined); |
There was a problem hiding this comment.
There’s a propertyHelper that could be used here
| assert.sameValue(symbol.description, 'test'); | ||
| assert.sameValue(symbol.hasOwnProperty('description'), false); | ||
|
|
||
| const empty = Symbol(); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| ---*/ | ||
|
|
||
| assert.throws(TypeError, function() { | ||
| Symbol.prototype.description.call(null); |
There was a problem hiding this comment.
This fails, but for the wrong reason. The getter is being called on Symbol.prototype. You should instead extract the getter with Object.getOwnPropertyDescriptor.
|
@ljharb @michaelficarra Thanks for the reviews. I have updated the PR, PTAL. |
michaelficarra
previously approved these changes
Jun 7, 2018
ljharb
previously approved these changes
Jun 7, 2018
gsathya
previously approved these changes
Jun 7, 2018
joyeecheung
dismissed stale reviews from gsathya, ljharb, and michaelficarra
via
21c2bab
@ljharb Sure! I've updated the PR, PTAL. |
ljharb
approved these changes
Jun 7, 2018
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: tc39/proposal-Symbol-description#5
V8 implementation in https://chromium-review.googlesource.com/c/v8/v8/+/1088871