Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests for static methods creation and fetching #2696

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

leobalter
Copy link
Member

Ref #2504
Ref tc39/ecma262#1490

@scole66 The tests are now correct with the current specs since tc39/ecma262#1490 has been merged.

There wasn't much to change I added some info content to help clarifying how the properties are set during the class evaluation and fetched from Object.getOwnPropertyNames and Object.getOwnPropertySymbols.

I also removed the assert messages as compareArray does a good job showing the actual and expected values if anything fails.

For the current tests failures, let's ping @codehag @anba @syg.

@leobalter leobalter requested a review from rwaldron July 9, 2020 18:03
@anba
Copy link
Contributor

anba commented Jul 9, 2020

SpiderMonkey test failures for these files are tracked at https://bugzilla.mozilla.org/show_bug.cgi?id=1629803.

@leobalter
Copy link
Member Author

Thank you, @anba, I value this information because sometime it's a bit hard to map failing tests to existing filed bugs, if any.

@leobalter leobalter changed the base branch from master to main July 15, 2020 17:41
@rwaldron
Copy link
Contributor

@syg heads for failures in V8

@rwaldron rwaldron merged commit 7e46572 into tc39:main Jul 15, 2020
@leobalter leobalter deleted the 2504/prop-names branch July 15, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants