From 64829e75023a699f70d1dc3c05e813f33dd572e4 Mon Sep 17 00:00:00 2001 From: Olivier Date: Sat, 18 Mar 2023 17:24:22 +0100 Subject: [PATCH] fix(ui) clicking on Empty Topic button display blank screen --- client/src/containers/Topic/Topic/Topic.jsx | 5 ++--- client/src/containers/Topic/Topic/TopicData/TopicData.jsx | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/client/src/containers/Topic/Topic/Topic.jsx b/client/src/containers/Topic/Topic/Topic.jsx index f03ff4445..756d6ab9d 100644 --- a/client/src/containers/Topic/Topic/Topic.jsx +++ b/client/src/containers/Topic/Topic/Topic.jsx @@ -84,8 +84,7 @@ class Topic extends Root { canEmptyTopic = () => { const { configs } = this.state; const res = configs.filter(config => config.name === 'cleanup.policy'); - if (res && res.length === 1 && res[0].value.includes('delete')) return true; - return false; + return res && res.length === 1 && res[0].value.includes('delete'); }; emptyTopic = () => { @@ -95,7 +94,7 @@ class Topic extends Root { .then(() => { toast.success(`Topic '${topicId}' will be emptied`); this.setState({ showDeleteModal: false }, () => { - this.topicData.current.getMessages(); + this.topicData.current._getMessages(false); }); }) .catch(() => { diff --git a/client/src/containers/Topic/Topic/TopicData/TopicData.jsx b/client/src/containers/Topic/Topic/TopicData/TopicData.jsx index 534fac08b..cb1616142 100644 --- a/client/src/containers/Topic/Topic/TopicData/TopicData.jsx +++ b/client/src/containers/Topic/Topic/TopicData/TopicData.jsx @@ -297,7 +297,7 @@ class TopicData extends Root { this._fetchMessages(requests); } - _getMessages(changePage = false) { + _getMessages = changePage => { const { selectedCluster, selectedTopic, nextPage } = this.state; const filters = this._buildFilters(); @@ -315,7 +315,7 @@ class TopicData extends Root { } else { this._setUrlHistory(filters); } - } + }; _fetchMessages(requests, changePage = false) { const { nextPage, pageNumber, partitionCount, recordCount, offsets } = this.state;