From 4135619510092237d5e32a09caa682b19f4de72f Mon Sep 17 00:00:00 2001 From: AlexisSouquiere Date: Fri, 17 May 2024 09:24:01 +0200 Subject: [PATCH] Add default value for github api and update doc --- docs/docs/configuration/authentifications/github.md | 6 ++++++ .../org/akhq/security/authentication/GithubApiClient.java | 2 +- src/main/resources/application.yml | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/docs/docs/configuration/authentifications/github.md b/docs/docs/configuration/authentifications/github.md index b08d09c01..cf35aa3ca 100644 --- a/docs/docs/configuration/authentifications/github.md +++ b/docs/docs/configuration/authentifications/github.md @@ -22,6 +22,12 @@ micronaut: auth-method: client-secret-post ``` +You can also override the GitHub API url if needed. Default value is https://api.github.com + +```yaml +github.api.url: https://override.api.github.com +``` + To further tell AKHQ to display GitHub SSO options on the login page and customize claim mapping, configure Oauth in the AKHQ config: ```yaml diff --git a/src/main/java/org/akhq/security/authentication/GithubApiClient.java b/src/main/java/org/akhq/security/authentication/GithubApiClient.java index faf1c3e50..4e1bd153a 100644 --- a/src/main/java/org/akhq/security/authentication/GithubApiClient.java +++ b/src/main/java/org/akhq/security/authentication/GithubApiClient.java @@ -8,7 +8,7 @@ @Header(name = "User-Agent", value = "Micronaut") @Header(name = "Accept", value = "application/vnd.github.v3+json, application/json") -@Client("${github.api.url}") +@Client("${github.api.url:`https://api.github.com`}") public interface GithubApiClient { @Get("/user") diff --git a/src/main/resources/application.yml b/src/main/resources/application.yml index 2e82e637f..e8b584688 100644 --- a/src/main/resources/application.yml +++ b/src/main/resources/application.yml @@ -71,7 +71,7 @@ micronaut: http: client: allow-block-event-loop: true - github.api.url: https://api.github.com + jackson: serialization: