Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing #123

Closed
vdice opened this issue Feb 12, 2020 · 2 comments
Closed

Tests failing #123

vdice opened this issue Feb 12, 2020 · 2 comments

Comments

@vdice
Copy link

vdice commented Feb 12, 2020

When make test is run, a few of the tests fail due to the test URL returning a 404 when not expected:

 $ make test
go get  -d
..
go test -v -parallel=4 ./...
=== RUN   TestRun
=== PAUSE TestRun
=== RUN   TestRun_recreate
--- FAIL: TestRun_recreate (0.67s)
    cli_test.go:71: "ghr -username ghtools -repository github-api-test run-recreate ./testdata" exits 11, want 0

        Failed to create GitHub release page: failed to create a release: POST https://api.github.com/repos/ghtools/github-api-test/releases: 404 Not Found []

...
--- FAIL: TestGHR_CreateRelease (0.39s)
    ghr_test.go:31: CreateRelease failed: failed to create a release: POST https://api.github.com/repos/ghtools/github-api-test/releases: 404 Not Found []
--- FAIL: TestRun (0.51s)
    cli_test.go:24: "ghr -username ghtools -repository github-api-test run ./testdata" exits 11, want 0

        Failed to create GitHub release page: failed to create a release: POST https://api.github.com/repos/ghtools/github-api-test/releases: 404 Not Found []

--- FAIL: TestGHR_CreateReleaseWithExistingRelease (1.15s)
    ghr_test.go:104: #0 CreateRelease failed: failed to create a release: POST https://api.github.com/repos/ghtools/github-api-test/releases: 404 Not Found []
--- FAIL: TestGitHubClient (1.17s)
    github_test.go:69: #0 CreateRelease failed: failed to create a release: POST https://api.github.com/repos/ghtools/github-api-test/releases: 404 Not Found []
FAIL
FAIL	github.com/tcnksm/ghr	2.574s
FAIL
make: *** [test] Error 1

https://github.com/ghtools/github-api-test appears to be the repo associated with the test server

@JehandadK
Copy link
Contributor

#130 Should address this.

@Songmu
Copy link
Collaborator

Songmu commented Sep 26, 2022

Fixed at #130

@Songmu Songmu closed this as completed Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants