Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max amount of exclude statements #624

Closed
alexander-zierhut opened this issue Oct 30, 2023 · 1 comment
Closed

Max amount of exclude statements #624

alexander-zierhut opened this issue Oct 30, 2023 · 1 comment

Comments

@alexander-zierhut
Copy link
Contributor

While working on #623, I tried a temporary fix by using the exclude statement like so:

minify
--recursive
--verbose
--exclude '**/folder1/**'
--exclude '**/folder2/**'
--exclude '**/folder3/**'
--output folder_output/
folder_input/

This results in:
minify: must specify --type in order to use stdin and stdout

Possibly relevant code

@tdewolff
Copy link
Owner

Thanks, this was silly...there was still some debugging code in the argp package which prevented from parsing too many arguments. Should be fixed now.

On the issue, --exclude allows to pass multiple values, such as: --exclude '**/folder1/**' '**/folder2/**' '**/folder3/**' would work fine. This might give unexpected results when it is followed immediately by the input files, as it would be included in the excludes, and not inputs: --exclude dir_to_exclude folder_input would be unexpected. You would need to do: --exclude dir_to_exclude -- folder_input. I'm not 100% convinced if this is the way of "least surprises" by users...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants