Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor CI #2565

Closed
ranm8 opened this issue Apr 8, 2020 · 5 comments
Closed

AppVeyor CI #2565

ranm8 opened this issue Apr 8, 2020 · 5 comments
Assignees
Labels
Milestone

Comments

@ranm8
Copy link
Member

ranm8 commented Apr 8, 2020

@davidfirst @GiladShoham as we all now AppVeyor is failing for a while now and and I'm worried we would find many regressions in Harmony for windows.
What can we do about it?

@ranm8 ranm8 added the type/bug label Apr 8, 2020
@ranm8 ranm8 added this to the harmony release v1.0 milestone Apr 8, 2020
@davidfirst
Copy link
Member

@ranm8 , here is the problem.
AppVeyor is extremely slow, it takes 1.5 hours to complete. Also, more often than not, it fails due to timeout. As a result, it's hard to enforce to keep it green in the current state that we push many times a day to the main branch.

we would find many regressions in Harmony for windows.

I'm sure we'll find many regressions on Windows. We can fix them now or fix them all once we finish. I'm good with both options. Let us know.

@ranm8
Copy link
Member Author

ranm8 commented Apr 8, 2020

I prefer to be in sync with Windows issues early in the development process and not find our how bad the situation is eventually. Can we use Circle instead? How can we pace the CI build time?

@davidfirst
Copy link
Member

Circle had this Beta version of Windows and Gilad registered to it. @GiladShoham , what's the status there?

@GiladShoham
Copy link
Member

There will be probably many issues with harmony on windows. My guess mainly tests mistakes with paths. But not necessarily.
Yes we can configure circle for windows. I think it's also out of beta already.
It require probably a day of work on configuration.
It will also might be a bit expensive since the windows machines are very strong therefore very expensive. With the Linux you can choose the hardware with windows not.
I can't estimate the prices without really running it.
Its also affected by the parallelism.
I'm sure it will eventually technology wise will be much better since circle is much better than appveyor. It will also put everything under one roof which is good and will be more stable and faster.
I really want to do it for a long time.. Just let me know if you want me to try migration to circle, try fix tests with appveyor or keep it to the end.
@ranm8

@GiladShoham
Copy link
Member

fixed by #2599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants