Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE: Demo environment doesnt support IE (production does work) #1163

Closed
GerbenBosschieter opened this issue Nov 15, 2019 · 8 comments
Closed
Assignees
Labels
Priority: Won't have Has been agreed by stakeholders as the least-critical, lowest-payback items, or not appropriate at. project-60 label for project issue #60 found in management repository

Comments

@GerbenBosschieter
Copy link

Main asssignee: @

Description

The demo environment is not supporting IE at all.
Some problems with Apache, Ie and Google Maps.
It doesn't work on production so there are no real users influenced by this problem.

Should we fix this ?

We should fix this If we are going to use the demo environment to let our clients play with the application. A lot of our clients still use IE and it gives negative impressions if we want to showcase or test something on demo without the front end working on IE.

@GerbenBosschieter GerbenBosschieter added the project-60 label for project issue #60 found in management repository label Nov 15, 2019
@maxvisser
Copy link
Contributor

valentin would need to dive into this abit to make it work; should check if it is really valuable to have this working. as it is something with google maps we could also decide to disable maps on IE on these environments

@GerbenBosschieter
Copy link
Author

is disabling Maps something thats easy to do for specifically the demo environment? I understand that it's currently being used by stakeholders

@maxvisser
Copy link
Contributor

yes its easy but all map functionality stops working.

@maxvisser
Copy link
Contributor

maxvisser commented Nov 22, 2019

QUICKFIX: disabled map on demo

@maxvisser maxvisser added the Priority: Won't have Has been agreed by stakeholders as the least-critical, lowest-payback items, or not appropriate at. label Nov 26, 2019
@maxvisser maxvisser reopened this Dec 12, 2019
@maxvisser
Copy link
Contributor

Found solution for this issue; in scripts.pug I included google maps after other libraries and this fixed the issue.

zloirock/core-js#567 (maybe something like this happened)

@maxvisser maxvisser assigned dev-rminds and unassigned maxvisser Dec 12, 2019
@maxvisser
Copy link
Contributor

still needs to be applied to develop and tested

@LindaForus
Copy link
Member

@maxvisser Fixed?

@maxvisser
Copy link
Contributor

No did this manually; needs to be added to the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Won't have Has been agreed by stakeholders as the least-critical, lowest-payback items, or not appropriate at. project-60 label for project issue #60 found in management repository
Projects
None yet
Development

No branches or pull requests

4 participants