Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly support slashes in Category names #209

Closed
amenk opened this issue Jan 21, 2021 · 1 comment
Closed

Properly support slashes in Category names #209

amenk opened this issue Jan 21, 2021 · 1 comment

Comments

@amenk
Copy link
Contributor

amenk commented Jan 21, 2021

See #194 #198

We have slashes in category names (something like Valves 1/2")

Describe the solution you'd like

In https://github.com/techdivision/import/blame/master/src/Assembler/CategoryAssembler.php#L152 we should use a CSV implode instead of a simple implode.

Describe alternatives you've considered

Removing slashes? but that is not an option :)

Additional context

If we have such a category tree

tree

This would lead twice to the key Foo/Bar, for ID = 2 as well as ID = 3, so the array indexes collide and the ID = 2 will be overwritten.
@amenk
Copy link
Contributor Author

amenk commented Jan 21, 2021

@DanieliMi will try to use the csvSerializier here to add escaping

@amenk amenk mentioned this issue Jan 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amenk