Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:greeting-fn option ignored on lein repl :connect #2631

Open
vemv opened this issue Nov 22, 2019 · 1 comment
Open

:greeting-fn option ignored on lein repl :connect #2631

vemv opened this issue Nov 22, 2019 · 1 comment
Labels

Comments

@vemv
Copy link
Contributor

vemv commented Nov 22, 2019

Hi,

I can't get the :greeting-fn to work on lein repl :connect.

Inspecting the source, it seems to me that that option is ignored for that specific if branch:

([project subcommand & opts]
(let [repl-profiles (project/profiles-with-matching-meta project :repl)
project (project/merge-profiles project repl-profiles)]
(if (= subcommand ":connect")
(client project (doto (connect-string project opts)
(->> (main/info "Connecting to nREPL at"))))

...There, opts is only used for obtaining a connection string, otherwise omitted.

wdyt?

Thanks - V

@technomancy
Copy link
Owner

Yep, looks like an oversight to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants