Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/register command permission based #6

Open
SSRPStevens opened this issue Jan 24, 2024 · 5 comments
Open

/register command permission based #6

SSRPStevens opened this issue Jan 24, 2024 · 5 comments

Comments

@SSRPStevens
Copy link

SSRPStevens commented Jan 24, 2024

Currently, there is no way to stop an individual from using /register [Server Owner's TeamSpeak ID] granting themselves access to the Owner's role if they happen to sync.

My suggestion would be to check if the ID being registered has already been registered to another user at a minimum. Also, to allow a certain role ID to override that check to ensure someone doesn't steal an ID they shouldn't have.

If this is not possible, at least turn off /register when Discord oauth is enabled. Edited By Techy: Moved to separate issue

@techy2493
Copy link
Owner

I'm going to split turn off /register into a separate issue.

@techy2493
Copy link
Owner

We have a separate command for the override, /tsid, but it should be rounded out with additional features. I will make a separate issue for that as well.

@techy2493
Copy link
Owner

Let's focus on, preventing users of the /register command from registering a tsid which is already used.

@techy2493
Copy link
Owner

Also see #12 for more information regarding the desirability of a single user having more than on TSID, that may impact how this command is re-implemented

@techy2493
Copy link
Owner

I believe this was actually addressed in V4, I will try to make time to test and will close this out in a day or two if so. It was inadvertent, so I may update this story to make the message the user receives when they do this more useful if it is ugly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants