Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC call over TCP is expensive!! #92

Closed
atton16 opened this issue Aug 20, 2017 · 4 comments
Closed

RPC call over TCP is expensive!! #92

atton16 opened this issue Aug 20, 2017 · 4 comments

Comments

@atton16
Copy link

atton16 commented Aug 20, 2017

I did a packet analysis and found that RPC call over TCP is too expensive. It cost 12 packets to perform each call when in fact it could simply leverage TCP keep-alive. RPC call should be less expensive than REST API call. Please fix this. Cheers.

@tedeh
Copy link
Owner

tedeh commented Aug 30, 2017

I don't have the time to look into this right now, but a more efficient implementation should be possible and you are most welcome to provide a hopefully backwards-compatible pull request with your ideas/requirements.

@atton16 atton16 closed this as completed Sep 14, 2017
@gzz2000
Copy link

gzz2000 commented Aug 7, 2021

Bumping this issue as I find that sometimes keepalive is a requirement when the RPC server keeps session information associated with each TCP connection. In that way, it no longer works if each time we have to start a new connection.

@tedeh
Copy link
Owner

tedeh commented Aug 7, 2021

This issue has been referenced from an important section in the README: https://github.com/tedeh/jayson#what-is-the-recommended-way-to-use-jayson

@gzz2000
Copy link

gzz2000 commented Aug 7, 2021

This issue has been referenced from an important section in the README: https://github.com/tedeh/jayson#what-is-the-recommended-way-to-use-jayson

You are right. Then this is purely a consideration on efficiency. Submitted a PR implementing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants