Error in connecting to database when using msnodesqlv8 driver and password has special character in it

[abhku]

I am using mssql with msnodesqlv8. I have database with password containing ; in it e.g. -'%;0&<,4#l} . SQL server allows password like this but when we use this kind of password the ODBC connection string doesn't works and gives Error : Login failed for user 'xxxx'.,Error: [Microsoft][SQL Server Native Client 11.0]Invalid connection string attribute

Expected behaviour:

Connection should work

Actual behaviour:

Connection is not working

Configuration:

{
  options: {
    instanceName: undefined,
    trustServerCertificate: false,
    abortTransactionOnError: true
  },
  pool: { max: 100, min: 1, idleTimeoutMillis: 50 },
  port: 1433,
  server: 'xxxxxxx',
  database: 'xxxxx',
  domain: undefined,
  user: 'xxxxx',
  password: "-'%;0&<,4#l}",
  connectionTimeout: 30000,
  requestTimeout: 120000
}

Software versions

• NodeJS: 16
• node-mssql: "^9.0.1"
• msnodesqlv8": "^3.0.1",
• SQL Server: Azure SQL

[abhku]

The password should be wrapped within {} and escape } with }}

[dhensby]

Interesting, that's a good catch - the way msnodesqlv8 works is that we provide an SQL connection string to it, and we should be escaping special chars when we construct that string which, clearly, is not happening...

[dhensby]

I've tried to fix this in #1479 - can you take a look and let me know if it fixes your problem

[abhku]

Yes, this fixes the problem

[github-actions]

🎉 This issue has been resolved in version 9.1.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀