chore!: drop node 16 and 19 support #1598
Conversation
.github/workflows/nodejs.yml
Outdated
| @@ -46,7 +46,7 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| node-version: [16.x, 18.x, 19.x] | |||
| node-version: [18.x, 19.x, 20.x, 21.x] | |||
There was a problem hiding this comment.
We can drop 19 support since it is no longer supported.
appveyor.yml
Outdated
| @@ -2,7 +2,6 @@ version: "{build}" | |||
|
|
|||
| environment: | |||
| matrix: | |||
| - nodejs_version: "16" | |||
| - nodejs_version: "18" | |||
| - nodejs_version: "19" | |||
There was a problem hiding this comment.
We can drop 19 support since it is no longer supported. Should we add 20 and 21 here?
There was a problem hiding this comment.
Yes, let's drop support for 19 and add 20 and 21.
There was a problem hiding this comment.
Just push a commit for adding 20, 21 and remove 19 👍 @arthurschreiber , the CI still expecting check for node 16 and 19, is this configurable from one of the yml files or it is a ci setting? 🤔
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1598 +/- ##
==========================================
- Coverage 79.15% 78.43% -0.73%
==========================================
Files 93 93
Lines 4860 4860
Branches 934 934
==========================================
- Hits 3847 3812 -35
- Misses 708 751 +43
+ Partials 305 297 -8 ☔ View full report in Codecov by Sentry. |
MichaelSun90
changed the title
|
🎉 This PR is included in version 17.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: Node.js 16.x and 19.x are no longer supported by `tedious`. (cherry picked from commit ddfa397)
BREAKING CHANGE: Node.js 16.x and 19.x are no longer supported by
tedious.