Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating ginkgomon for Ginkgo V2 #35

Closed
onsi opened this issue Jan 7, 2022 · 4 comments
Closed

Updating ginkgomon for Ginkgo V2 #35

onsi opened this issue Jan 7, 2022 · 4 comments

Comments

@onsi
Copy link
Collaborator

onsi commented Jan 7, 2022

heyo @tedsuo - hope you are well! Are you still maintaining ifrit these days? A few CF folks are running into issues trying to upgrade to Ginkgo V2 and using the ginkgomon helper that depends on Ginkgo V1. Would you be up for me submitting a PR that adds a ginkgomon_v2 package that depends on Ginkgo V2 instead to unblock folks?

I can also upgrade all the things to Ginkgo v2 if you'd like - but can just keep it simple and focused on the new package instead.

Thanks!
@tedsuo
Copy link
Owner

tedsuo commented Jan 9, 2022

Hey hey!! Great to hear from you. Yes, I'm happy to accept PR's. I agree with your approach to make a separate package.

@onsi
Copy link
Collaborator Author

onsi commented Jan 9, 2022

thanks @tedsuo ! will circle back in a few

@onsi onsi mentioned this issue Jan 9, 2022
Closed
@tedsuo
Copy link
Owner

tedsuo commented Jan 27, 2022

@onsi have you tried to use v2? We good on this one?

@onsi
Copy link
Collaborator Author

onsi commented Jan 27, 2022

yep should be all good. thanks for the ping!

@onsi onsi closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tedsuo @onsi