Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the mesh is not indexed index it #19

Closed
fire opened this issue Oct 14, 2022 · 2 comments
Closed

If the mesh is not indexed index it #19

fire opened this issue Oct 14, 2022 · 2 comments

Comments

@fire
Copy link
Contributor

fire commented Oct 14, 2022

b1a8cba#diff-d33d32e5c95b94168ba2419046959073375cd13d9c6d5dbd2956e67a50cfbb92R37

Might be another crash.

@fire
Copy link
Contributor Author

fire commented Oct 14, 2022

Probably want to check if p_mesh_arrays is sized ARRAY_MAX and all the requirements like vertex array existing is good.

@tefusion
Copy link
Owner

tefusion commented Oct 15, 2022

Should be fixed by dca566a. I'll try some more glb test meshes later cause haven't found a mesh triggering this. the ARRAY_MAX check and vertex_array existing check are directly in the format generator which will just return 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants