Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In recv, if char is something unexpected, it will loop until error_count > retry without re-evaluating char #44

Closed
g-frenette opened this issue Jun 17, 2020 · 1 comment

Comments

@g-frenette
Copy link

In xmodem/init.py, between lines 472 and 510, we have a while loop and if clauses to determine the appropriate action to take. I had a case where I would have the variable char being something unexpected and then the execution would go in the else statement. However, char is never re-evaluated in that else. It would then just loop for retries in the else. I believe that adding this statement: char = self.getc(1, timeout) after line 504 would solve this undesirable behavior.

Thanks for your time!

@jquast
Copy link
Collaborator

jquast commented Jun 11, 2023

I believe this is fixed in next release by c99d3e7, thanks for the report!

@jquast jquast closed this as completed Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants