Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix issue #7 on crc checksum failure #11

Merged
merged 15 commits into from
Dec 31, 2014
Merged

Bugfix issue #7 on crc checksum failure #11

merged 15 commits into from
Dec 31, 2014

Commits on Dec 29, 2014

  1. Use functional tests (tox + py.test + lrzsz package) 

    This implements travis-ci integration, yet untested. I will have to clone the
repository to allow travis-ci access for testing.  Once I added tox support,
I added python3 testing -- which immediately failed.  I spent some time adding
python3 support.  Some of it may incur some small overhead.  We can address
these if we decide on a new API for YMODEM (multi-file, file-like iface) support.

Additionally, debug logging is less verbose in the case of not logging each
successful checksum -- and more verbose in the case of indicating each and
every step through the transfer.  These were decorated as I went with the
python3 porting process.
    @jquast
    jquast committed Dec 29, 2014
    Configuration menu
    Copy the full SHA
    a6c24ab View commit details
    Browse the repository at this point in the history

  2. wire-in tox to Makefile 'tests' target

    @jquast
    jquast committed Dec 29, 2014
    Configuration menu
    Copy the full SHA
    999cc3e View commit details
    Browse the repository at this point in the history

  3. FIX -- Too many arguments for logging format string

    @jquast
    jquast committed Dec 29, 2014
    Configuration menu
    Copy the full SHA
    a4061e0 View commit details
    Browse the repository at this point in the history

  4. Not enough arguments for logging format string

    @jquast
    jquast committed Dec 29, 2014
    Configuration menu
    Copy the full SHA
    0483a00 View commit details
    Browse the repository at this point in the history

  5. bugfix old-style checksum and add functional tests

    @jquast
    jquast committed Dec 29, 2014
    Configuration menu
    Copy the full SHA
    3228e70 View commit details
    Browse the repository at this point in the history

  6. make failing test cases for CRC issue #7

    @jquast
    jquast committed Dec 29, 2014
    Configuration menu
    Copy the full SHA
    492043f View commit details
    Browse the repository at this point in the history

  7. ignore /build

    @jquast
    jquast committed Dec 29, 2014
    Configuration menu
    Copy the full SHA
    71c9def View commit details
    Browse the repository at this point in the history

  8. Fix missing document links in https://pythonhosted.org/xmodem/xmodem.… 

    …html

URLS at the top for the TXT documents fail, because the docs/ are not
provided with a source distribution
    @jquast
    jquast committed Dec 29, 2014
    Configuration menu
    Copy the full SHA
    b6b173d View commit details
    Browse the repository at this point in the history

  9. coveralls support

    @jquast
    jquast committed Dec 29, 2014
    Configuration menu
    Copy the full SHA
    a14caad View commit details
    Browse the repository at this point in the history

  10. Bugfix issue #7 on crc checksum failure 

    When a CRC checksum failure occurs and NAK is sent,

1. we should purge any awaiting stdin as suggested by
   ymodem.txt and documented therein, i would suppose
   this may only be for ymodem, which has a kind of
   readahead buffer, though.  For xmodem local testing
   piped with lrzsz, no data is purged.

2. we should read the next start-of-header block, as
   is usually done when the checksum is valid -- this
   causes our 'seq1' to be SOH or STX, and seq2 fails
   1's complement and subsequent failures about unexpected
   sequence occur, otherwise.
    @jquast
    jquast committed Dec 29, 2014
    Configuration menu
    Copy the full SHA
    9b03fc2 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'functional-tests' into fixing-crcfails

    @jquast
    jquast committed Dec 29, 2014
    Configuration menu
    Copy the full SHA
    de55d20 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'fix-missing-docs' into fixing-crcfails

    @jquast
    jquast committed Dec 29, 2014
    Configuration menu
    Copy the full SHA
    3749063 View commit details
    Browse the repository at this point in the history

  13. bump version, add changes section, add self as author :)

    @jquast
    jquast committed Dec 29, 2014
    Configuration menu
    Copy the full SHA
    75af6ba View commit details
    Browse the repository at this point in the history

  14. use codecs.open for bytes/str py2/3 read() issue

    @jquast
    jquast committed Dec 29, 2014
    Configuration menu
    Copy the full SHA
    471e4df View commit details
    Browse the repository at this point in the history

  15. another version

    @jquast
    jquast committed Dec 29, 2014
    Configuration menu
    Copy the full SHA
    42b026c View commit details
    Browse the repository at this point in the history