Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture step information for in-toto/slsa Provenance #271

Closed
pxp928 opened this issue Oct 27, 2021 · 4 comments
Closed

Capture step information for in-toto/slsa Provenance #271

pxp928 opened this issue Oct 27, 2021 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@pxp928
Copy link
Member

pxp928 commented Oct 27, 2021

Feature request

Adding further detail into the taskrun payload by adding environment for each step within a taksrun. (https://slsa.dev/provenance/v0.1)

"recipe": { "type": "<URI>", "definedInMaterial": /* integer */, "entryPoint": "<STRING>", "arguments": { /* object */ }, "environment": { /* object */ }

This added information would provide more information for each step within the taskrun and capture proper entry-points, arguments and image information for each step. This update would allow for better verification via in-toto verify in the future.

Use case

This added information would make the in-toto/salsa provenance created by tekton chains be similar to the tekton provenance and capture missing information that can be used by in-toto verify

@pxp928 pxp928 added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 27, 2021
@pxp928 pxp928 changed the title Capture step information for in-toto/salsa Provenance Capture step information for in-toto/slsa Provenance Oct 27, 2021
@priyawadhwa
Copy link
Contributor

Hey @pxp928 thanks for opening this! Just an FYI, I have a proposal open for slsa v0.2 which will include this information (slsa-framework/slsa#179).

Until that goes in, I think the correct place for this would be in recipe.arguments -- we could create recipe.arguments.steps and include all of this extra info!

@pxp928
Copy link
Member Author

pxp928 commented Oct 27, 2021

Hey @priyawadhwa! Awesome I didn't realize that there were updates already happening to the slsa framework. So should I change the POC from recipe.environment to recipe.arguments.steps for the time being?

@priyawadhwa
Copy link
Contributor

Yah let's do that!

@priyawadhwa
Copy link
Contributor

Hey @pxp928 I'm going to close this issue because I think it's been done! Just an FYI, I just merged support for slsa-provenance v0.2 in #291, so that should be out with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants