Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade sigstore/cosign dependency to v1.3.1 #289

Closed
wants to merge 1 commit into from
Closed

Upgrade sigstore/cosign dependency to v1.3.1 #289

wants to merge 1 commit into from

Conversation

priyawadhwa
Copy link
Contributor

this should help unblock #284 :)

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign priyawadhwa
You can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 23, 2021
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/oci/oci.go 10.1% 8.4% -1.7

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/oci/oci.go 10.1% 8.5% -1.6

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/oci/oci.go 10.1% 8.5% -1.6

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/storage/oci/oci.go 10.1% 8.5% -1.6

@rgreinho
Copy link
Contributor

rgreinho commented Nov 23, 2021 •
edited
Loading

I am more learning from this PR than anything else, but the new functions provide a nice abstraction level compared to the previous ones and the package reorganization (ociremote, mutate) makes complete sense.

@priyawadhwa priyawadhwa mentioned this pull request Nov 29, 2021
Merged
@tekton-robot
Copy link

@priyawadhwa: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2021
@priyawadhwa
Copy link
Contributor Author

closing as this was merged with #291

@priyawadhwa priyawadhwa deleted the upgrade-cosign branch November 30, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@font font Awaiting requested review from font

@lukehinds lukehinds Awaiting requested review from lukehinds

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@priyawadhwa @tekton-robot @rgreinho