Add securityContext to controller pod #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds securityContext to the controller pod which has been missing till now. This is in line with securityContext in other Tekton components like pipeline and triggers. There are a few reasons why securityContext is important to add to the controller: - the securityContext specifies the user and group as 65532 which is what is used by the distroless nonroot image that ko uses in the controller image. - securityContext is also useful in distributions like OpenShift which assign a random user while running a pod. If securityContext is not set, the controller fails with permission denied errors like in tektoncd#320
tekton-robot
added
the
size/XS
vdemeester
reviewed
Jan 21, 2022
mattmoor
approved these changes
Jan 21, 2022
tekton-robot
added
the
approved
priyawadhwa
approved these changes
Jan 27, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds securityContext to the controller pod which has been
missing till now. This is in line with securityContext in other Tekton
components like pipeline and triggers.
There are a few reasons why securityContext is important to add to the
controller:
what is used by the distroless nonroot image that ko uses in the
controller image.
assign a random user while running a pod. If securityContext is not
set, the controller fails with permission denied errors like in Error uploading signature and attestation #320