Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PipelineRun attestation buildType #568

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Update PipelineRun attestation buildType #568

merged 2 commits into from
Sep 26, 2022

Conversation

lcarva
Copy link
Contributor

@lcarva lcarva commented Sep 23, 2022

Changes

To match the structure of the buildType of TaskRun attestation, change
the buildType of PipelineRun attestations from:
https://tekton.dev/attestations/chains/pipelinerun@v2
to:
tekton.dev/v1beta1/PipelineRun

Also, remove unused TektonID const. This is leftover from when this value was used for the buildType value of TaskRun attestations.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@lcarva
Update PipelineRun attestation buildType
ad2a44d 
To match the structure of the buildType of TaskRun attestation, change
the buildType of PipelineRun attestations from:
    https://tekton.dev/attestations/chains/pipelinerun@v2
to:
    tekton.dev/v1beta1/PipelineRun

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@lcarva
Remove unused TektonID const
7ebd49a 
This is leftover from when this value was used for the buildType value
of TaskRun attestations.

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 23, 2022
wlynch
wlynch approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2022
@tekton-robot tekton-robot merged commit c502d8a into tektoncd:main Sep 26, 2022
@lcarva lcarva deleted the update-build-type branch September 26, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlynch wlynch wlynch approved these changes

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees

@wlynch wlynch

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcarva @tekton-robot @wlynch