Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a binary for Affinity Assistant used as a placeholder pod #2640

Closed
jlpettersson opened this issue May 18, 2020 · 6 comments · Fixed by #3014
Closed

Create a binary for Affinity Assistant used as a placeholder pod #2640

jlpettersson opened this issue May 18, 2020 · 6 comments · Fixed by #3014
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@jlpettersson
Copy link
Member

This was requested in #2630 (comment)

Expected Behavior

A small, minimal binary, e.g. an Go http service.

Actual Behavior

We currently use an Nginx image for this.

@dibyom dibyom added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 19, 2020
@vdemeester vdemeester added this to the Pipelines 0.13 🐱 milestone Jun 4, 2020
@vdemeester
Copy link
Member

@bobcatfish as quickly discussed today, the hardcoded nginx image is most likely gonna be a blocker for openshift-pipelines 😅 We can use a flag for this and still using nginx but allowing openshift-pipelines (and other integrator) to customize the image.

@imjasonh
Copy link
Member

imjasonh commented Jun 4, 2020

Does the image have to expose an HTTP service? Or just run indefinitely? Either way, a simple purpose-built Go binary + image sgtm.

Related #2562 #2714

@jlpettersson
Copy link
Member Author

Or just run indefinitely?

Just run indefinitely. We could potentially use it for other things as well, if we want.

For this use case, it is just a pod with specific labels, so that taskRun-pods can configure podAffinity to attract that pod, so they are scheduled to the same Node.

@imjasonh
Copy link
Member

imjasonh commented Jun 4, 2020

It could (not sure) be nice to reuse the nop image (see #2714) and give it two modes: exit successfully immediately no matter what (nop), or run indefinitely no matter what (affinity assistant).

@dlorenc
Copy link
Contributor

dlorenc commented Jul 20, 2020

It could (not sure) be nice to reuse the nop image (see #2714) and give it two modes: exit successfully immediately no matter what (nop), or run indefinitely no matter what (affinity assistant).

The run indefinitely option sounds a lot like the k8s pause container: https://www.ianlewis.org/en/almighty-pause-container

we could maybe reuse that one - it is already optimized to be tiny and run forever with 0 CPU footprint.

@dlorenc
Copy link
Contributor

dlorenc commented Jul 20, 2020

@ghost ghost assigned imjasonh and unassigned ghost Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants