Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to specify PodTemplate for Affinity Assistant #2679

Closed
jlpettersson opened this issue May 23, 2020 · 0 comments · Fixed by #2743
Closed

Add option to specify PodTemplate for Affinity Assistant #2679

jlpettersson opened this issue May 23, 2020 · 0 comments · Fixed by #2743
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jlpettersson
Copy link
Member

jlpettersson commented May 23, 2020 •
edited
Loading

From #2630 (comment)

Expected Behavior

That Tekton is a flexible system that can be configured for custom needs.

Actual Behavior

The Affinity Assistant is a static StatefulSet that can not be configured.

Use cases

  • For using Tekton only on a subset of Nodes, a NodeSelector can be set. This must now be set on the Affinity Assistant instead of on TaskRun pods

  • When a platform has other requirements on specifying ResourceRequests/Limits. This should be set in the PodTemplate for the Affinity Assistant.

/kind feature
@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 23, 2020
@jlpettersson jlpettersson mentioned this issue Jun 3, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate NodeSelector and Tolerations to Affinity Assistant jlpettersson/pipeline
2 participants
@jlpettersson @tekton-robot