-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The affinity-assistant pods are still spawning after disabling the associated feature-flag: disable-affinity-assistant #2979
Comments
/cc @jlpettersson |
Is real and is really annoying |
The affinity assistant code tries to read the config value from context or default pipeline/pkg/reconciler/pipelinerun/affinity_assistant.go Lines 223 to 226 in abb677d
The pipelinerun controller has its own config store, which does not include feature flags, so the code above will always return the default. This should be indirectly solved by: #2938 :) |
Seem to been introduced / changed in #2637 |
This should be fixed in 0.14.3 and in master with :
I think we can "safely" close this. If this turns out to still be a bug, please comment here and I'll re-open 👼 |
I seem to still be seeing this with 0.14.3... |
Expected Behavior
No affinity-assistant pods should spawn
Actual Behavior
There is an affinity-assistant pod spawning for each pipelinerun task that manages to execute
Steps to Reproduce the Problem
kubectl edit configmap feature-flags -n tekton-pipelines
and adddisable-affinity-assistant
as follows:Additional Info
Kubernetes version:
Output of
kubectl version
:Tekton Pipeline: v0.14.2
The text was updated successfully, but these errors were encountered: