Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intregration test for metrics #4223

Open
khrm opened this issue Sep 9, 2021 · 12 comments
Open

Intregration test for metrics #4223

khrm opened this issue Sep 9, 2021 · 12 comments
Assignees
Labels
area/metrics Issues related to metrics area/testing Issues or PRs related to testing help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@khrm
Copy link
Contributor

khrm commented Sep 9, 2021

Request

We require integration integration tests for metrics also. For now, metrics is experimental but if we want to move ahead, then a test which can captures issue happening in metrics is must.

/kind testing
/kind test

@khrm
Copy link
Contributor Author

khrm commented Sep 9, 2021

A recent pr by myself was working fine in some of the conditions I test but later on I found that it introduces race condition for some metrics and metrics stuck. I resolved that.

@vdemeester
Copy link
Member

/area testing

@tekton-robot tekton-robot added the area/testing Issues or PRs related to testing label Sep 9, 2021
@khrm khrm changed the title Intregration test for metrics Intregration and e2e test for metrics Sep 9, 2021
@khrm khrm changed the title Intregration and e2e test for metrics Intregration test for metrics Sep 9, 2021
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 8, 2021
@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 7, 2022
@jerop
Copy link
Member

jerop commented Jan 11, 2022

/lifecycle frozen

we need fix this to catch the issues we've been seeing with metrics

needed before v1 (@lbernick)

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 11, 2022
@QuanZhang-William
Copy link
Member

/assign @QuanZhang-William

@lbernick lbernick added this to the Pipelines v0.42 milestone Nov 7, 2022
@dibyom dibyom added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 29, 2022
@pritidesai
Copy link
Member

@lbernick to find someone to work on this!

@pritidesai
Copy link
Member

@afrittoli is willing to help out if someone can work on this, this is important for V1. Thanks @afrittoli !

@XinruZhang
Copy link
Member

XinruZhang commented Jan 27, 2023

/assign

I'll take this on since I had written some test codes (but still working on making the test case pass :p) if @afrittoli hasn't started :)

@pritidesai
Copy link
Member

Pipelines WG - thank you @XinruZhang for taking this up, moving it to the next milestone!

@lbernick lbernick added the area/metrics Issues related to metrics label Mar 15, 2023
@pritidesai
Copy link
Member

@XinruZhang moving this out of any milestone, please feel free to take it up whenever you can, thanks!

@pritidesai pritidesai removed this from the Pipelines v0.47 milestone Mar 21, 2023
@afrittoli afrittoli added this to the Pipeline v1 milestone Jun 27, 2023
@afrittoli
Copy link
Member

@khrm are you still working on this issue? We marked it as "blocking" for a v1 release and we would like to make a v1 release in July. If you are working on it, will you be able to solve this until then? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics Issues related to metrics area/testing Issues or PRs related to testing help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
Status: Todo
Status: Todo
Development

No branches or pull requests

10 participants