Pipelines controller removing label from PipelineRun on reconcilation

[sm43]

In Pipelines As Code, we create PipelineRun and then Update the PipelineRun with a Label.

Recently we noticed the label is missing, on debugging it more, we found when pipelines controller adds tekton.dev/pipeline label on the PipelineRun, it is removing the other label.

  --- PipelineRun pac-app-pipelines/pac-app-7-fp9f2 v392837 (2022-08-08T13:53:33+05:30) (gen. 1)
    +++ PipelineRun pac-app-pipelines/pac-app-7-fp9f2 v392871 (2022-08-08T13:53:33+05:30) (gen. 1)
    @@ -32,7 +32,6 @@
  pipelinesascode.tekton.dev/branch: main
  -    pipelinesascode.tekton.dev/check-run-id: "772154487234"
       pipelinesascode.tekton.dev/event-type: pull_request
       pipelinesascode.tekton.dev/git-provider: github
       pipelinesascode.tekton.dev/original-prname: pac-app-7
    @@ -42,9 +41,10 @@
  pipelinesascode.tekton.dev/state: started
  pipelinesascode.tekton.dev/url-org: sm43
  pipelinesascode.tekton.dev/url-repository: pac-app
  +    tekton.dev/pipeline: pac-app-7-fp9f2
    name: pac-app-7-fp9f2
    namespace: pac-app-pipelines
    -  resourceVersion: "392837"
  +  resourceVersion: "392871"
    uid: bcc2a3dc-e9a8-4ba0-9257-2b9308fc2d43
    spec:
      params:

How can we avoid this from happening? if this is a race condition

Slack Thread https://tektoncd.slack.com/archives/CLCCEBUMU/p1659949444059689

[sm43]

cc @imjasonh @afrittoli @vdemeester

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[vdemeester]

/assign

[vdemeester]

/lifecycle frozen

[vdemeester]

I think this got fixed be #5597 and will not even be relevent once #5146 is fixed, so I will go ahead and close this issue.