Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getTaskRunCreations to be explicit on getting TaskRuns #6143

Closed
JeromeJu opened this issue Feb 9, 2023 · 3 comments · Fixed by #6293
Closed

Refactor getTaskRunCreations to be explicit on getting TaskRuns #6143

JeromeJu opened this issue Feb 9, 2023 · 3 comments · Fixed by #6293
Assignees
@airycanon
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@JeromeJu
Copy link
Member

JeromeJu commented Feb 9, 2023

The usage of getTaskRunCreations in the pipelineRun reconciler test suite verifies implementation details (API calls) rather than the outputs we care about (TaskRuns themselves), making the tests harder to understand. This should be refactored to not rely on this.

Originally posted by @lbernick in #6135 (comment)

/kind cleanup
@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 9, 2023
@JeromeJu JeromeJu changed the title RefactorgetTaskRunCreations to be explicit on getting TaskRuns Refactor getTaskRunCreations to be explicit on getting TaskRuns Feb 9, 2023
@JeromeJu JeromeJu mentioned this issue Feb 9, 2023
Closed
7 tasks
@Hussain0520
Copy link

Hey @JeromeJu is someone working on this?

@JeromeJu
Copy link
Member Author

Hey @JeromeJu is someone working on this?

@Hussain0520 there is not. Please feel free to self-assign:)

@airycanon
Copy link
Contributor

/assign

@airycanon airycanon mentioned this issue Mar 5, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@airycanon airycanon

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor getTaskRunCreations in the pipelineRun reconciler test suite
4 participants
@airycanon @JeromeJu @tekton-robot @Hussain0520