minor consistency fixes

[EliZucker]

Changes

1. Attempt to make bracket usage consistent across testing. To give some background, in an earlier PR, I wrote some validation tests, and kept the additional tests in line with the existing tests in that file. However, I got feedback that I should collapse the brackets, so I had to change the existing tests in that file as well to match that formatting. I'm not sure if Tekton has decided on that type of styling rule, but IMO it's probably a good idea to keep them consistent so that users aren't forced to either arbitrarily follow one of the existing styles (increasing the project inconsistency), or refactor the entire existing test file themselves.

2. Adjust taskrunpod files to match gofmt results. When runnning gofmt, those 3 files are the only ones that need adjustment. It's interesting that build-tests didn't see that (I assumed it checked linting but I'm probably wrong). It's possible that that it only checks for differences in the generated files or my computer somehow has a different gofmt version.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added) - No functionality changed
• Includes docs (if user facing) No user facing changes
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

[dibyom]

/lgtm

[afrittoli]

Thanks for this. I think it's a good idea to keep the style consistent; I feel however that unless we enforce it via CI there will more PR like this one needed in the future.
Is there a way to enforce the test formatting automatically?

[bobcatfish]

hahaha take that @dlorenc 😜

[EliZucker]

Thanks for this. I think it's a good idea to keep the style consistent; I feel however that unless we enforce it via CI there will more PR like this one needed in the future.
Is there a way to enforce the test formatting automatically?

Not sure about the brackets, but I think the tests can be modified to at least verify that gofmt doesn't suggest something different; the logic would be similar to the current codegen enforcement.

[bobcatfish]

Thanks for this. I think it's a good idea to keep the style consistent; I feel however that unless we enforce it via CI there will more PR like this one needed in the future.
Is there a way to enforce the test formatting automatically?

If someone can find a tool that'll check for this that we can add to our linting then I'm all for it! This feels to me like a minor enough thing that it's not worth putting too much time into tho.

( @EliZucker would probably be worth writing up an issue in our dogfooding epic #267 about making sure we are running go fmt !)

/approve
/meow space

[tekton-robot]

@bobcatfish:

In response to this:

Thanks for this. I think it's a good idea to keep the style consistent; I feel however that unless we enforce it via CI there will more PR like this one needed in the future.
Is there a way to enforce the test formatting automatically?

If someone can find a tool that'll check for this that we can add to our linting then I'm all for it! This feels to me like a minor enough thing that it's not worth putting too much time into tho.

( @EliZucker would probably be worth writing up an issue in our dogfooding epic #267 about making sure we are running go fmt !)

/approve
/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish, dibyom, EliZucker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bobcatfish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment