-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jerop as an owner 🎉 #3620
Add Jerop as an owner 🎉 #3620
Conversation
@jerop has been reviewed 32 PRs in pipelines (https://github.com/tektoncd/pipeline/pulls?q=is%3Apr+reviewed-by%3Ajerop+-author%3Ajerop) and has authored 27 PRs against this repo (https://github.com/tektoncd/pipeline/pulls/jerop) including when expressions tektoncd#3135, in addition to making significant improvements to our processes (e.g. defining design principles tektoncd/community#171 and recently proposing topical areas of ownership) Thanks for all your hard work @jerop!!
@tektoncd/core-maintainers |
whoa you are FAST @sbwsg :D 🏎️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/meow
🎉
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🎉 🎉 🎉 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai, sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
While we wait for more OWNERS @afrittoli @dibyom @dlorenc @imjasonh (who is on leave right now, i think we can safely consider him 👍 !) /hold |
/lgtm 👍 |
oh hai @imjasonh XD |
+1! |
/lgtm |
/lgtm |
/hold cancel |
Jerop was added as Pipelines Owner in tektoncd/pipeline#3620
Jerop was added as Pipelines Owner in tektoncd/pipeline#3620
Changes
@jerop has been reviewed 32 PRs in pipelines
(https://github.com/tektoncd/pipeline/pulls?q=is%3Apr+reviewed-by%3Ajerop+-author%3Ajerop)
and has authored 27 PRs against this repo (https://github.com/tektoncd/pipeline/pulls/jerop)
including when expressions #3135,
in addition to making significant improvements to our processes
(e.g. defining design principles tektoncd/community#171
and recently proposing topical areas of ownership)
Thanks for all your hard work @jerop!!
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes