Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove condition test builder #4119

Closed
wants to merge 1 commit into from
Closed

Remove condition test builder #4119

wants to merge 1 commit into from

Conversation

tylerauerbeck
Copy link

Signed-off-by: Tyler Auerbeck tauerbec@redhat.com

Changes

  • Small change to remove last usage of tb.Condition builder

Part of #3178

/kind cleanup
/area testing

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n] Docs included if any changes are user facing
  • [y] Tests included if any functionality added or changed
  • [y] Follows the commit message standard
  • [y] Meets the Tekton contributor standards (including
    functionality, content, code)
  • [y] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@tylerauerbeck
Remove condition builder
2ec6a02 
- remove condition test builder
- replace with actual implementation of condition

Signed-off-by: Tyler Auerbeck <tauerbec@redhat.com>
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/testing Issues or PRs related to testing labels Jul 27, 2021
@tekton-robot tekton-robot requested review from imjasonh and a user July 27, 2021 02:16
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dibyom
You can assign the PR to them by writing /assign @dibyom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 27, 2021
@tekton-robot
Copy link
Collaborator

Hi @tylerauerbeck. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 27, 2021
@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2021
@tekton-robot
Copy link
Collaborator

@tylerauerbeck: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-tekton-pipeline-build-tests 2ec6a02 link /test pull-tekton-pipeline-build-tests
pull-tekton-pipeline-alpha-integration-tests 2ec6a02 link /test pull-tekton-pipeline-alpha-integration-tests
pull-tekton-pipeline-integration-tests 2ec6a02 link /test pull-tekton-pipeline-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

1 similar comment
@tekton-robot
Copy link
Collaborator

@tylerauerbeck: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-tekton-pipeline-build-tests 2ec6a02 link /test pull-tekton-pipeline-build-tests
pull-tekton-pipeline-alpha-integration-tests 2ec6a02 link /test pull-tekton-pipeline-alpha-integration-tests
pull-tekton-pipeline-integration-tests 2ec6a02 link /test pull-tekton-pipeline-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ghost
Copy link

ghost commented Jul 27, 2021

Does this mean we can also remove internal/builder/v1alpha1/condition.go?

@vdemeester
Copy link
Member

ping @tylerauerbeck

@jerop
Copy link
Member

jerop commented Oct 5, 2021

this change and more was made in #4270 so closing this pr -- thank you @tylerauerbeck!

@jerop jerop closed this Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees
No one assigned
Labels
area/testing Issues or PRs related to testing kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tylerauerbeck @tekton-robot @vdemeester @jerop