-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing internal/builder/v1alpha1 and all usages #4270
Removing internal/builder/v1alpha1 and all usages #4270
Conversation
My hero 😍 |
There’s more to come! I think I may be able to finish off removing
everything next week.
|
50c3c72
to
5d3ff17
Compare
1d52646
to
03e827b
Compare
For future reference, is there a good/easy shortcut to set things up to run the e2e tests locally so I don't have to push and wait 20+ minutes to see why they failed? I swear I had something set up way back in the day, but it's Been Some Time. =) EDIT: Ok, I found my ancient script to set up my project and cluster in GKE...let's see if that does the trick...yeah, seems good. Is there any way to run against a local k8s cluster, rather than having to run in GKE? |
03e827b
to
bfe27f1
Compare
Ok, finally got my test cluster working ( |
Part of tektoncd#3178. `internal/builder/v1beta1` is still there - I did remove it from some of the files under `pkg/reconciler` where I was removing `internal/builder/v1alpha1` usage while I was there, but there are still plenty of references left, including _1,487_ in `pkg/reconciler/pipelinerun/pipelinerun_test.go`. Yikes! Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
bfe27f1
to
49019b5
Compare
/retest |
fwiw, at my current rate, it might take me up to two weeks to grind out removing all the |
Check the |
it's a beast 👹 I appreciate all your efforts to cleanup and remove builders 🙏 😻 |
fwiw, this PR is ready to go - I'm planning on getting rid of |
When in doubt:
This change looks GREAT to me. 😎 /lgtm |
...ok, looks like I'll have the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/meow |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tb.PipelineRunServiceAccountNameTask("task1", "task1SA"), | ||
tb.PipelineRunServiceAccountNameTask("task2", "task2SA"), | ||
)), | ||
pr: &v1alpha1.PipelineRun{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm personally not a big fan of embedding YAML in the tests like that, but I'm not opposed to it per se. Lemme finish up removing internal/builder
completely and then let's have a follow-up issue for the YAML approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure sounds good, thanks @abayer 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(spoiler: I'll probably end up doing the move to YAML approach if there's a consensus on that change, since I've got a good chunk of free time, but I'm so dang close to finishing removing internal/builder
that I want to put that to bed first. =) )
Changes
Part of #3178.
internal/builder/v1beta1
is still there - I did remove it from some of the files underpkg/reconciler
where I was removinginternal/builder/v1alpha1
usage while I was there, but there are still plenty of references left, including 1,487 inpkg/reconciler/pipelinerun/pipelinerun_test.go
. Yikes!/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes