-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Migration for latest C++ Features. #3509
Comments
Not sure if we already have an issue about migrating to c++11 (maybe you could have a look to the open issues to check it) but anyway it seems to be a good idea and, as far as a know, a pre-requisite for the MongoDB drive migration. Thus, I think it would be a good idea to do that but before starting to work in the MongoDB driver migration. However, some questions I have about it:
Thanks! |
I didn't find any open Issue related to the migration.
Thanks :) |
It seems to be good news :) Thus, I'd suggest going ahead with a PR replacing auto_ptr with unique_ptr. Behavior at run time will be checked by travis when you cast the PR with a pretty good coverage based on tests, don't worry about it. |
That's great !! I'll share these changes ASAP. |
The pre-requisite disappeared at the end because we are using a C-based driver. However, it may be a good idea to move to C++11 in some moment, so this issue stills. |
As I am working on latest mongocxx-driver which needs c++ 11 feature to get compile successfully, I came across some auto_ptr related errors in mongodbBackend (Which is basically deprecated in C++ 11).
As a resolution we just need to study unique_ptr and replace it smartly with auto_ptr.
So just wondering if we're having any plans for the same ?
The text was updated successfully, but these errors were encountered: