diff --git a/pkg/reconciler/reconciler_test.go b/pkg/reconciler/reconciler_test.go index cb69d87..d66adf7 100644 --- a/pkg/reconciler/reconciler_test.go +++ b/pkg/reconciler/reconciler_test.go @@ -160,11 +160,19 @@ var _ = BeforeSuite(func() { err = os.WriteFile(testConfig, configData, 0o600) Expect(err).ToNot(HaveOccurred()) + err = os.Setenv(operatorConfigEnv, testConfig) + Expect(err).ToNot(HaveOccurred()) + err = os.Setenv(healthcheck.NodenameEnv, "test-node") + Expect(err).ToNot(HaveOccurred()) }) var _ = AfterSuite(func() { err := os.RemoveAll(tmpDir) Expect(err).ToNot(HaveOccurred()) + err = os.Unsetenv(operatorConfigEnv) + Expect(err).ToNot(HaveOccurred()) + err = os.Unsetenv(healthcheck.NodenameEnv) + Expect(err).ToNot(HaveOccurred()) }) func TestReconciler(t *testing.T) { @@ -257,7 +265,6 @@ var _ = Describe("NodeConfigReconciler", func() { var _ = Describe("NodeNetworkConfigReconciler", func() { Context("NewNodeNetworkConfigReconciler() should", func() { It("return error if cannot init FRR Manager", func() { - os.Setenv(operatorConfigEnv, testConfig) frrManagerMock := mock_frr.NewMockManagerInterface(mockctrl) c := createClient() frrManagerMock.EXPECT().Init(gomock.Any()).Return(fmt.Errorf("init error")) @@ -265,10 +272,8 @@ var _ = Describe("NodeNetworkConfigReconciler", func() { frrManagerMock, nl.NewManager(mock_nl.NewMockToolkitInterface(mockctrl))) Expect(err).To(HaveOccurred()) Expect(r).To(BeNil()) - os.Unsetenv(operatorConfigEnv) }) It("create new reconciler", func() { - os.Setenv(operatorConfigEnv, testConfig) frrManagerMock := mock_frr.NewMockManagerInterface(mockctrl) c := createClient() frrManagerMock.EXPECT().Init(gomock.Any()).Return(nil) @@ -276,12 +281,10 @@ var _ = Describe("NodeNetworkConfigReconciler", func() { frrManagerMock, nl.NewManager(mock_nl.NewMockToolkitInterface(mockctrl))) Expect(err).ToNot(HaveOccurred()) Expect(r).ToNot(BeNil()) - os.Unsetenv(operatorConfigEnv) }) }) Context("Reconcile() should", func() { It("return no error if there is no config to reconcile", func() { - os.Setenv(operatorConfigEnv, testConfig) frrManagerMock := mock_frr.NewMockManagerInterface(mockctrl) c := createClient() frrManagerMock.EXPECT().Init(gomock.Any()).Return(nil) @@ -291,10 +294,8 @@ var _ = Describe("NodeNetworkConfigReconciler", func() { Expect(r).ToNot(BeNil()) err = r.Reconcile(context.TODO()) Expect(err).ToNot(HaveOccurred()) - os.Unsetenv(operatorConfigEnv) }) It("return no error if there is no config to reconcile", func() { - os.Setenv(operatorConfigEnv, testConfig) frrManagerMock := mock_frr.NewMockManagerInterface(mockctrl) c := createClient() frrManagerMock.EXPECT().Init(gomock.Any()).Return(nil) @@ -304,12 +305,8 @@ var _ = Describe("NodeNetworkConfigReconciler", func() { Expect(r).ToNot(BeNil()) err = r.Reconcile(context.TODO()) Expect(err).ToNot(HaveOccurred()) - os.Unsetenv(operatorConfigEnv) }) It("return error if cannot configure FRR", func() { - os.Setenv(operatorConfigEnv, testConfig) - os.Setenv(healthcheck.NodenameEnv, "test-node") - frrManagerMock := mock_frr.NewMockManagerInterface(mockctrl) netlinkMock := mock_nl.NewMockToolkitInterface(mockctrl) netlinkMock.EXPECT().LinkList().Return([]netlink.Link{}, nil) @@ -325,13 +322,8 @@ var _ = Describe("NodeNetworkConfigReconciler", func() { Expect(r).ToNot(BeNil()) err = r.Reconcile(context.TODO()) Expect(err).To(HaveOccurred()) - os.Unsetenv(healthcheck.NodenameEnv) - os.Unsetenv(operatorConfigEnv) }) It("return error if failed to reload FRR", func() { - os.Setenv(operatorConfigEnv, testConfig) - os.Setenv(healthcheck.NodenameEnv, "test-node") - frrManagerMock := mock_frr.NewMockManagerInterface(mockctrl) netlinkMock := mock_nl.NewMockToolkitInterface(mockctrl) netlinkMock.EXPECT().LinkList().Return([]netlink.Link{}, nil) @@ -347,12 +339,8 @@ var _ = Describe("NodeNetworkConfigReconciler", func() { Expect(r).ToNot(BeNil()) err = r.Reconcile(context.TODO()) Expect(err).To(HaveOccurred()) - os.Unsetenv(healthcheck.NodenameEnv) - os.Unsetenv(operatorConfigEnv) }) It("return error if cannot configure networking", func() { - os.Setenv(operatorConfigEnv, testConfig) - os.Setenv(healthcheck.NodenameEnv, "test-node") frrManagerMock := mock_frr.NewMockManagerInterface(mockctrl) netlinkMock := mock_nl.NewMockToolkitInterface(mockctrl) netlinkMock.EXPECT().LinkList().Return([]netlink.Link{}, nil).Times(3) @@ -368,8 +356,6 @@ var _ = Describe("NodeNetworkConfigReconciler", func() { Expect(r).ToNot(BeNil()) err = r.Reconcile(context.TODO()) Expect(err).To(HaveOccurred()) - os.Unsetenv(healthcheck.NodenameEnv) - os.Unsetenv(operatorConfigEnv) }) }) })