Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax errors are offset incorrectly when tabs are used #54

Closed
KristianLyng opened this issue Oct 31, 2019 · 1 comment
Closed

Syntax errors are offset incorrectly when tabs are used #54

KristianLyng opened this issue Oct 31, 2019 · 1 comment
Labels
bug Something isn't working core/config Anything dealing with the configuration subsystem
Milestone

Comments

@KristianLyng
Copy link
Collaborator

I knew this going in, but I never fixed it/wrote an issue on it....

When calculate how far to indent when underlining syntax errors, we don't account for how some characters are wider than others. Most critical is tabs, which tend to be 8 character wide, but this can also include other none-1-char-wide-chars (e.g.: emojis).

Random test-case reveals this.

offset

@KristianLyng KristianLyng added bug Something isn't working core/config Anything dealing with the configuration subsystem labels Oct 31, 2019
@KristianLyng KristianLyng modified the milestones: v1.0-ish, 0.3 Nov 4, 2019
@KristianLyng
Copy link
Collaborator Author

Resolved with #62

@KristianLyng KristianLyng modified the milestones: next, 0.4 Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core/config Anything dealing with the configuration subsystem
Projects
None yet
Development

No branches or pull requests

1 participant