Reflexil 2.0

[ali-hm]

Hi,
Please update Reflexil plugin to v 2.0. it is already released for Redgate .Net Reflector.
Thank you

[tsviatko]

Yep we have this on our list and we'll get to it soon.

Of course, you are more than welcome to help us with that now that our source is available here. We'll gladly consider a pull request with that update.

[sailro]

I am also thinking of directly integrating the JD plugin into the main Reflexil repo. Now that I wrote everything needed to support ILSpy, it should be easy. And it will be easier for you to not upgrade your codebase each time a new version is released.

[tsviatko]

That is great Sebastien. Could you do this? If there's anything we could help with just let me know.

[sailro]

Yes, I will start working on this soon.

[sailro]

I made a quick review of the API surface, and I would need some stuff to properly integrate everything.

1- Have access to the list of all assemblies loaded into JustDecompile. You already expose a IAssemblyManagerService, so It would be great to have a property like:

IEnumerable<IAssemblyDefinition> LoadedAssemblies

2- Override ToString() for all objects implementing [IAssemblyDefinition, ..., IFieldDefinition, etc.]. In fact all objects forwarding data from your Mono.Cecil implementation should also forward the ToString(). It should not break anything as your assemblies are obfuscated and currently those objects only return a non human readable Namespace.Typename as ToString(). And this should be useful for a better member matching with alternate code models (and great for debugging).

3- Expose something to hot replace an assembly given a filename and a stream. I made a pull request for ILSpy and Redgate also implemeted this into Reflector. This allow Reflexil to craft an assembly in memory and to give this assembly back to the 'host'. Something like this in the IAssemblyManagerService:

IAssemblyDefinition HotReplaceAssembly(string file, Stream stream)

This should also transparently refresh the treeview and re-select the proper node to preserve user selection. See https://github.com/icsharpcode/ILSpy/pull/523/files. Reflexil currently calls this after member injection/deletion and allow the user to manualy sync after a method alteration for exemple.
Here is demo of this feature with ILSpy:
https://www.youtube.com/watch?v=ZhancUbQN2k (you can quick move to 3'36)

4- ITreeViewNavigatorService should expose the active treeview item like:

ITreeViewItem ActiveItem

Feel free to send me a beta build :)

[tsviatko]

OK we can easily do all that. The chances are we are going to have a deliverable some time around Jan 20th. We have a release coming up the next week and that's why the delay.

I'll be in touch again once we've done everything on our side. Thanks for the input. I really appreciate this.

[sailro]

Great. Another request if possible on IEventAggregator :

AssemblyLoadedEvent : CompositePresentationEvent<IAssemblyDefinition>
AssemblyUnloadedEvent : CompositePresentationEvent<IAssemblyDefinition>

[tsviatko]

Should not be a problem.

[tsviatko]

I am mailing a beta of JD with the new API to you now. Please, check it out.

[sailro]

Seems that I am not in the mailing list. Can you add me please? sebastien[at]lebreton[dot]fr
Thanks

[tsviatko]

I sent it to an old address of your I had from years ago. Should be with you now.

[sailro]

Nope still nothing. :(

[tsviatko]

Well I have no failure notification or anything. That's really weird. Could you send me an e-mail to tsviatko.yovtchev[at]telerik[dot]com? I'll try replying to your message with and without attachment.

[sailro]

Working on it...
https://github.com/sailro/Reflexil/tree/justdecompile