Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling with j and k keys is not smooth. #83

Closed
michaelfresco opened this issue Feb 22, 2017 · 9 comments · Fixed by #182
Closed

Scrolling with j and k keys is not smooth. #83

michaelfresco opened this issue Feb 22, 2017 · 9 comments · Fixed by #182

Comments

@michaelfresco
Copy link

I recently switched to Safari and love this plugin. Coming from Chrome/Vimium I noticed however that scrolling isn't that smooth. In addition, the scrolling is quite slow to my taste. It'd be really cool if you could set the amount of lines you scroll down. (say 4x or 9x).

@martinbohman
Copy link

You can change "Scroll Size" in options.

@rdewolff
Copy link

I think he means that the scroll is not smooth and would require some code update.

A smooth scrolling is for example http://jsfiddle.net/TeqkQ/

@martinbohman
Copy link

I'm referring to this:

In addition, the scrolling is quite slow to my taste. It'd be really cool if you could set the amount of lines you scroll down. (say 4x or 9x).

@simeg
Copy link
Collaborator

simeg commented Dec 3, 2017

#44 has some useful info

@dylan-chong
Copy link

dylan-chong commented Jan 20, 2018

Surely for d and u you could make it a little smoother. j and k don't move by much so I don't think it's a huge problem, but d and u do make rather sudden movements

@michaelfresco
Copy link
Author

michaelfresco commented Jan 20, 2018

I think that the people who have been using vimium on Chrome probably recognize what I was talking about. J/K are way less janky on Chrome (with vimium) than on Safari. And it also scrolls down quicker.

@adrianob
Copy link

Scrolling with j and k also causes some weird behavior on some websites(slashdot.org for instance), which does not happen with vimium. Would you accept a PR using an entirely different approach for this?

@simeg
Copy link
Collaborator

simeg commented May 9, 2018

@adrianob I'm sorry to hear that. Yes, we would of course accept a PR with an improvement! 😄That's the point of open source software, if you ask me :)

@jacobchrismarsh
Copy link

Added smooth scrolling in #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants