Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check the number of warnings in dmesg for each test #600

Open
RomanBelozerov opened this issue Mar 22, 2024 · 2 comments
Open

check the number of warnings in dmesg for each test #600

RomanBelozerov opened this issue Mar 22, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good to start Start form this tasks if you're new in the framework Infrastructure The framework reworking and extensions low priority
Milestone

Comments

@RomanBelozerov
Copy link
Contributor

We have tests with a lot of warning messages from Tempesta in dmesg (t_leaks, t_stress e.t.c.). These tests do not check and not expect these messages, and also these warnings are duplicates and do not make sense. Please add check to cleanup section after each test. For example:

def setUp():
    ...
    self.addCleanup(self.check_warning_count_in_dmesg)
    ...
             
def check_warning_count_in_dmesg(self):
    warnings_n = len(self.oops.log_findall('Warning'))
    if self.check_warning_count_in_dmesg and warnings_n > 5:
         raise Exception("...")

Please add a variable or decorator to disable this logic. As check_warning_count_in_dmesg in this example.

@RomanBelozerov RomanBelozerov added enhancement New feature or request low priority Infrastructure The framework reworking and extensions good to start Start form this tasks if you're new in the framework labels Mar 22, 2024
@RomanBelozerov RomanBelozerov added this to the 1.0 - GA milestone Mar 22, 2024
@krizhanovsky
Copy link
Contributor

Also please keep in mind that Tempesta FW itself in certain cases generates too many warnings and this should be fixed on Tempesta's side, so if you face the case of too many warnings in dmesg, then probably it could make sense to report an issue for Tempesta FW.

@KonsKo KonsKo self-assigned this Sep 14, 2024
@RomanBelozerov
Copy link
Contributor Author

We have unlimited_rate_on_tempesta_node decorator to disable ratelimit in dmesg. So you should check all the tests that use it, probably, they hide unexpected entries in the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good to start Start form this tasks if you're new in the framework Infrastructure The framework reworking and extensions low priority
Projects
None yet
Development

No branches or pull requests

3 participants