We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We assumed incorrectly that OSs won't give out recently bound ports, but tests reveal it may. Fix https://github.com/temporalio/cli/blob/main/temporalcli/devserver/freeport.go to:
GetFreePort() (int, error)
GetFreePort()
Probably don't even need a separate file anymore, this can be a simple single-method utility with the rest of the dev server stuff
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Describe the solution you'd like
We assumed incorrectly that OSs won't give out recently bound ports, but tests reveal it may. Fix https://github.com/temporalio/cli/blob/main/temporalcli/devserver/freeport.go to:
GetFreePort() (int, error)
call and none of that extra port-provider stuffGetFreePort()
listener also accept a socket connection before closing both the listener and socket and returning the portProbably don't even need a separate file anymore, this can be a simple single-method utility with the rest of the dev server stuff
The text was updated successfully, but these errors were encountered: