Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] SDKs should not fatal the worker on any error without a retry period #218

Open
cretz opened this issue Jan 25, 2023 · 0 comments
Open

[Feature Request] SDKs should not fatal the worker on any error without a retry period #218

cretz opened this issue Jan 25, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Jan 25, 2023

Is your feature request related to a problem? Please describe.

Today Go (and probably Java) will fatal error the worker if server returns InvalidArgument or NamespaceNotFound. These were originally assumed to be unrecoverable errors but we are now understanding at least InvalidArgument is recoverable (server sends InvalidArgument if the gRPC deadline is too close to now).

Describe the solution you'd like

Every SDK should react the same to seeing a worker error. They should probably mimic core in that they retry for so long, even fatal ones, before actually being fatal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cretz @josh-berry