default namespace setup #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Jul 3, 2023
bergundy
reviewed
Jul 3, 2023
| - name: DEFAULT_NAMESPACE | ||
| value: "{{ .Values.defaultnamespace.setup.name }}" | ||
| - name: DEFAULT_NAMESPACE_RETENTION | ||
| value: "{{ .Values.defaultnamespace.setup.retention }}" |
There was a problem hiding this comment.
This doesn’t support tls afaict, which is a fairly common requirement when setting up the server.
bergundy
reviewed
Jul 3, 2023
| - name: create-default-namespace | ||
| image: "{{ $.Values.admintools.image.repository }}:{{ $.Values.admintools.image.tag }}" | ||
| imagePullPolicy: {{ $.Values.admintools.image.pullPolicy }} | ||
| command: ['sh', '-c', 'tctl --ns $(DEFAULT_NAMESPACE) namespace describe || tctl --ns $(DEFAULT_NAMESPACE) namespace register --rd $(DEFAULT_NAMESPACE_RETENTION) --desc "Default namespace for Temporal Server."'] |
There was a problem hiding this comment.
Can you please use temporal cli instead of the soon to be deprecated tctl?
There was a problem hiding this comment.
I think this command is missing quotes around the variables
nikanmog
approved these changes
Oct 9, 2023
debugger24
reviewed
Oct 23, 2023
Comment on lines
302
to
303
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
Suggested change
| {{- end }} | |
| {{- end }} | |
| {{- end }} | |
| --- | |
| {{- end }} |
fm2022aa
reviewed
Jan 16, 2024
| enabled: false | ||
| name: default | ||
| backoffLimit: 100 | ||
| retention: 1 |
fm2022aa
reviewed
Jan 16, 2024
| defaultnamespace: | ||
| setup: | ||
| enabled: false | ||
| name: default |
robholland
added
enhancement
|
Implemented in #550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Optional job to create a default namespace.
Why?
Current deployment needs a manual step
Checklist
Closes
How was this tested:
Tested on k8s with postgresql DB created by zalando postgres operator
Any docs updates needed?