Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close all explicitly created NativeConnection #395

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Close all explicitly created NativeConnection #395

merged 1 commit into from
Nov 29, 2024
+98 −70

Conversation

mjameswh
Copy link
Contributor

What was changed

  • Add a finally block containing await connection.close() for all native connections that are explicitly created from the code. Not doing so prevents the worker process from exiting.

dandavison
dandavison approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@dandavison dandavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjameswh mjameswh enabled auto-merge (squash) November 29, 2024 23:43
@mjameswh mjameswh merged commit a07b78a into temporalio:main Nov 29, 2024
75 checks passed
@mjameswh mjameswh deleted the close-connections branch November 29, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandavison dandavison dandavison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjameswh @dandavison