Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Clarify in workflow constructor exception that DI is not supported #361

Open
cretz opened this issue Oct 28, 2024 · 0 comments · May be fixed by #379
Open

[Feature Request] Clarify in workflow constructor exception that DI is not supported #361

cretz opened this issue Oct 28, 2024 · 0 comments · May be fixed by #379
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Oct 28, 2024 •
edited
Loading

Describe the solution you'd like

Current message is "System.ArgumentException: Workflow named is not instantiable" when trying to register a workflow Temporal cannot instantiate. Add a sentence clarifying that DI is intentionally not supported, e.g. "System.ArgumentException: Workflow named is not instantiable. Dependency injection is not supported in workflows. Workflows must be deterministic and self-contained with a lifetime controlled by Temporal."
@cretz cretz added the enhancement New feature or request label Oct 28, 2024
cretz added a commit to cretz/temporal-sdk-dotnet that referenced this issue Dec 9, 2024
@cretz
Fix child workflow already exists and minor README updates
590d938 
Fixes temporalio#371
Fixes temporalio#368
Fixes temporalio#361
cretz added a commit to cretz/temporal-sdk-dotnet that referenced this issue Dec 9, 2024
@cretz
Fix child workflow already exists and minor README updates
85c289d 
Fixes temporalio#371
Fixes temporalio#368
Fixes temporalio#361
@cretz cretz linked a pull request Dec 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix child workflow already exists and minor README updates cretz/temporal-sdk-dotnet
1 participant
@cretz