Aligning OnWorkflow with OnActivity and adding unit tests to confirm …

…behavior is coherent (#1128)

Aligning OnWorkflow with OnActivity and adding unit tests to confirm behavior is coherent

internal/workflow_testsuite.go

@@ -388,19 +388,19 @@ func (e *TestWorkflowEnvironment) OnWorkflow(workflow interface{}, args ...inter
 	var call *mock.Call
 	switch fType.Kind() {
 	case reflect.Func:
-		fnType := reflect.TypeOf(workflow)
-		if err := validateFnFormat(fnType, true); err != nil {
+		if err := validateFnFormat(fType, true); err != nil {
 			panic(err)
 		}
 		fnName, _ := getWorkflowFunctionName(e.impl.registry, workflow)
 		if alias, ok := e.impl.registry.getWorkflowAlias(fnName); ok {
 			fnName = alias
 		}
+		e.impl.registry.RegisterWorkflowWithOptions(workflow, RegisterWorkflowOptions{DisableAlreadyRegisteredCheck: true})
 		call = e.mock.On(fnName, args...)
 	case reflect.String:
 		call = e.mock.On(workflow.(string), args...)
 	default:
-		panic("activity must be function or string")
+		panic("workflow must be function or string")
 	}
 
 	return e.wrapCall(call)

internal/workflow_testsuite_test.go

@@ -27,6 +27,7 @@ package internal
 import (
 	"context"
 	"errors"
+	"github.com/stretchr/testify/assert"
 	"strings"
 	"testing"
 	"time"
@@ -291,3 +292,28 @@ func TestActivityAssertNumberOfCalls(t *testing.T) {
 	env.AssertNumberOfCalls(t, "namedActivity", 3)
 	env.AssertNumberOfCalls(t, "otherActivity", 0)
 }
+
+func HelloWorkflow(_ Context, name string) (string, error) {
+	return "", errors.New("unimplemented")
+}
+
+func TestWorkflowMockingWithoutRegistration(t *testing.T) {
+	testSuite := &WorkflowTestSuite{}
+	env := testSuite.NewTestWorkflowEnvironment()
+	env.OnWorkflow(HelloWorkflow, mock.Anything, mock.Anything).Return(
+		func(ctx Context, person string) (string, error) {
+			return "Hello " + person + "!", nil
+		})
+	env.ExecuteWorkflow("HelloWorkflow", "Temporal")
+	require.NoError(t, env.GetWorkflowError())
+	var result string
+	err := env.GetWorkflowResult(&result)
+	require.NoError(t, err)
+	require.Equal(t, "Hello Temporal!", result)
+}
+
+func TestActivityMockingByNameWithoutRegistrationFails(t *testing.T) {
+	testSuite := &WorkflowTestSuite{}
+	env := testSuite.NewTestWorkflowEnvironment()
+	assert.Panics(t, func() { env.OnActivity("SayHello", mock.Anything, mock.Anything) }, "The code did not panic")
+}