Prevent cache eviction race (#1013)

In some server tests the race detector noticed that SetPreviousStartedEventID can race with cache removal which happens on the cache eviction thread.
temporalio · Jan 27, 2023 · 3b37e0f · 3b37e0f
1 parent 1fe6824
commit 3b37e0f
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/internal/internal_task_handlers.go b/internal/internal_task_handlers.go
@@ -1166,6 +1166,8 @@ func (w *workflowExecutionContextImpl) SetCurrentTask(task *workflowservice.Poll
 }
 
 func (w *workflowExecutionContextImpl) SetPreviousStartedEventID(eventID int64) {
+	w.mutex.Lock() // This call can race against the cache eviction thread - see clearState
+	defer w.mutex.Unlock()
 	w.previousStartedEventID = eventID
 }