Remove version_set_id from CompatibleVersionSet (#1089)

temporalio · Apr 14, 2023 · a090256 · a090256
1 parent eaa3802
commit a090256
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/internal/worker_version_sets.go b/internal/worker_version_sets.go
@@ -99,8 +99,7 @@ func (s *WorkerBuildIDVersionSets) Default() string {
 
 // CompatibleVersionSet represents a set of worker build ids which are compatible with each other.
 type CompatibleVersionSet struct {
-	versionSetId string
-	BuildIDs     []string
+	BuildIDs []string
 }
 
 func workerVersionSetsFromProtoResponse(response *workflowservice.GetWorkerBuildIdCompatibilityResponse) *WorkerBuildIDVersionSets {
@@ -119,8 +118,7 @@ func workerVersionSetsFromProto(sets []*taskqueuepb.CompatibleVersionSet) []*Com
 	result := make([]*CompatibleVersionSet, len(sets))
 	for i, s := range sets {
 		result[i] = &CompatibleVersionSet{
-			versionSetId: s.GetVersionSetId(),
-			BuildIDs:     s.GetBuildIds(),
+			BuildIDs: s.GetBuildIds(),
 		}
 	}
 	return result

diff --git a/internal/worker_version_sets_test.go b/internal/worker_version_sets_test.go
@@ -45,14 +45,14 @@ func Test_WorkerVersionSets_fromProtoResponse(t *testing.T) {
 			name: "normal sets",
 			response: &workflowservice.GetWorkerBuildIdCompatibilityResponse{
 				MajorVersionSets: []*taskqueuepb.CompatibleVersionSet{
-					{BuildIds: []string{"1.0", "1.1"}, VersionSetId: "1"},
-					{BuildIds: []string{"2.0"}, VersionSetId: "2"},
+					{BuildIds: []string{"1.0", "1.1"}},
+					{BuildIds: []string{"2.0"}},
 				},
 			},
 			want: &WorkerBuildIDVersionSets{
 				Sets: []*CompatibleVersionSet{
-					{BuildIDs: []string{"1.0", "1.1"}, versionSetId: "1"},
-					{BuildIDs: []string{"2.0"}, versionSetId: "2"},
+					{BuildIDs: []string{"1.0", "1.1"}},
+					{BuildIDs: []string{"2.0"}},
 				},
 			},
 		},